Comments on: Flaw: Digging into Collaborators http://misko.hevery.com Testability Explorer Sat, 13 Mar 2010 19:20:13 -0500 http://wordpress.org/?v=2.8 hourly 1 By: Niceboomer and the future of changes » Blog Archive » Guide: Writing Testable Code http://misko.hevery.com/code-reviewers-guide/flaw-digging-into-collaborators/comment-page-1/#comment-3069 Niceboomer and the future of changes » Blog Archive » Guide: Writing Testable Code Fri, 12 Feb 2010 20:51:46 +0000 http://misko.hevery.com/?page_id=325#comment-3069 [...] Flaw #2: Digging into Collaborators [...] [...] Flaw #2: Digging into Collaborators [...]

]]> By: Einführung in TDD & Clean Code Talks | geekcloud.org http://misko.hevery.com/code-reviewers-guide/flaw-digging-into-collaborators/comment-page-1/#comment-2427 Einführung in TDD & Clean Code Talks | geekcloud.org Sun, 22 Nov 2009 14:50:55 +0000 http://misko.hevery.com/?page_id=325#comment-2427 [...] Flaw #2: Digging into Collaborators [...] [...] Flaw #2: Digging into Collaborators [...]

]]> By: Rafael Naufal http://misko.hevery.com/code-reviewers-guide/flaw-digging-into-collaborators/comment-page-1/#comment-614 Rafael Naufal Fri, 23 Jan 2009 16:00:06 +0000 http://misko.hevery.com/?page_id=325#comment-614 Great post, Misko. It helps a lot improving the code design by showing the problems of not passing explicitly the objects to methods or constructors.  Just one remark: In the "Problem: Law of Demeter Violated to Inappropriately make a Service Locator" section,  there's no assignment to the Lock member variable at the UpdateBug constructor. Great post, Misko. It helps a lot improving the code design by showing the problems of not passing explicitly the objects to methods or constructors.  Just one remark: In the “Problem: Law of Demeter Violated to Inappropriately make a Service Locator” section,  there’s no assignment to the Lock member variable at the UpdateBug constructor.

]]> By: Guide to Writing Testable Code / CODEISPOETRY http://misko.hevery.com/code-reviewers-guide/flaw-digging-into-collaborators/comment-page-1/#comment-461 Guide to Writing Testable Code / CODEISPOETRY Thu, 11 Dec 2008 01:38:01 +0000 http://misko.hevery.com/?page_id=325#comment-461 [...] Flaw #2: Digging into Collaborators [...] [...] Flaw #2: Digging into Collaborators [...]

]]> By: Vlad http://misko.hevery.com/code-reviewers-guide/flaw-digging-into-collaborators/comment-page-1/#comment-415 Vlad Fri, 28 Nov 2008 10:02:36 +0000 http://misko.hevery.com/?page_id=325#comment-415 Hi! I enjoy your posts and I've been inspired to add more test to my code. My question is if it is a flaw or not if one method has an argument that is both used directly and also to access some sub-object. For example in the LoginPage, if login() needs both the client and the authenticator, is it okay to just send the client as a parameter, or should one send both client and authenticator? best regards, Vlad Hi!
I enjoy your posts and I’ve been inspired to add more test to my code.

My question is if it is a flaw or not if one method has an argument that is both used directly and also to access some sub-object.

For example in the LoginPage, if login() needs both the client and the authenticator, is it okay to just send the client as a parameter, or should one send both client and authenticator?

best regards,
Vlad

]]> By: Guide to Writing Testable Code | Miško Hevery http://misko.hevery.com/code-reviewers-guide/flaw-digging-into-collaborators/comment-page-1/#comment-389 Guide to Writing Testable Code | Miško Hevery Wed, 26 Nov 2008 18:04:00 +0000 http://misko.hevery.com/?page_id=325#comment-389 [...] Flaw #2: Digging into Collaborators [...] [...] Flaw #2: Digging into Collaborators [...]

]]>