Glad to be of service.

Thanks for the great talk!

I watched it on Youtube last night and couldn’t agree with you more. I went to work this morning and looked at a project I implemented. Boy, so many if statements, so I tried to use polymorphism, and then it was so much easier to understand. My code is so much clearer! I was in a really happy mood for the whole day..even now!

I feel like my skill somewhere moved up to another level. Thank you!

I’ve been watching the Clean Code Talks on YouTube and learning lots. Thanks for the effort.

Sorry to comment late for this posting, but I’m still trying to
understand something about replacing conditionals with polymorphism.

I understand how you can extract each “leg” of a conditional into its
own class, then instantiate the behavior that you want from a factory
class.

What I don’t understand is how do the factories know which classes to
instantiate? It seems like the ideal place for a conditional.

In Ruby we have a few meta helpers like this:

class PeelerFactory   thin_skinned_fruits = ["apple", "pear"]   my_fruits = []    
thin_skinned_fruits.each do |f|
     my_fruits << Object.const_get(”#{f.capitalize}Peeler”).new  
endendclass ApplePeeler; endclass PearPeeler; end

Is this what you have in mind? Or is it OK
to use conditionals in factory classes?class PeelerFactory  

def initialize(type)  @type = type  end  def peeler    case @type    when “apple”       ApplePeeler.new    when “pear”       PearPeeler.new    end  end
end
class ApplePeeler; end
class PearPeeler; end

Thanks!Scott

In order to get rid of ‘if/case’ you need to replace it with polymorphism. Create a class ‘Role’ and than subclass it into ‘Admin’, ‘Manager’, etc… When you call disable on the ‘Role’ class depending on whether the role is Admin or a Manager different code will execute.

Regards, Kai

Regards,
nazgob